shustsud comments

Results 10 comments of


                                            shustsud

Convert project to typescript.

@rkaw92 Sent PR to DefinitelyTyped(pulsar-client). https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50229 If the PR was merged, I think you can set message listener for consumer.

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

@lhotari I think this fix is not related to PR https://github.com/apache/bookkeeper/pull/4171. This issue also occurs when LedgerHandle#sendAddSuccessCallbacks is called singly. I confirmed PR https://github.com/apache/bookkeeper/pull/4171 and knew that threads other than...

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

@lhotari I see. The cause of this issue is the following call to LedgerHandle#sendAddSuccessCallbacks. https://github.com/apache/bookkeeper/blob/234b817cdb4e054887ffd5e42eaed25dc02daf63/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java#L203-L206 If LedgerHandle#sendAddSuccessCallbacks is called at this timing, it may cause other entries that need to...

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

> I confirmed PR https://github.com/apache/bookkeeper/pull/4171 and knew that threads other than BookKeeperClientWorker-OrderedExecutor call LedgerHandle#sendAddSuccessCallbacks. > I think the current fix is not sufficient, so I will fix this PR. Fixed...

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

@lhotari > Why does that logic exist in the first place? Are entry ids guaranteed to be continuous? Sorry, I don't know if entry ids are guaranteed to be continuous....

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

@jvrao @merlimat @nicoloboschi @dlg99 @hangc0276 @codelipenghui Could you review this PR? This PR is not directly related to the https://github.com/apache/bookkeeper/pull/4171, so I think it can be merged once the review...

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

@graysonzeng > If this PR is merged, I think the repair of #4171 may be improved. Is the issue with https://github.com/apache/bookkeeper/pull/4171 that BookKeeperClientWorker-OrderedExecutor thread and pulsar-io thread called LedgerHandle#sendAddSuccessCallbacks at...

Fixed issue where entries could not be read due to mismatch between the ensemble on metadata and the actual written bookies.

Although this PR was originally submitted last year, I’ve tested it with the latest codebase and confirmed that the issue still persists. The issue is described here: https://github.com/apache/bookkeeper/issues/4097 This PR...

Incorrect msgBacklog value

@codelipenghui thank you for your comment. Add comments to the ticket if there is additional information.

[improve] Enable hostname specification as a script argument for topology script

rerun failure checks