pulsar-client-node icon indicating copy to clipboard operation
pulsar-client-node copied to clipboard

Convert project to typescript.

Open aahmed-se opened this issue 6 years ago • 9 comments

Target version 3.3

aahmed-se avatar Mar 14 '19 07:03 aahmed-se

An alternative is to create a @types/pulsar-client-node definition in https://github.com/DefinitelyTyped/DefinitelyTyped

frejonb avatar Nov 30 '19 08:11 frejonb

that works to

aahmed-se avatar Nov 30 '19 12:11 aahmed-se

I've added v1.0 types to DefinitelyTyped.

npm install -D @types/pulsar-client

bwalendz avatar Jan 23 '20 17:01 bwalendz

@bwalendz please add that to the readme.md

aahmed-se avatar Jan 24 '20 10:01 aahmed-se

@bwalendz @aahmed-se Thank you for adding the definition and document! By the way, do you have any idea about the procedure / policy to maintain them?

nkurihar avatar Jan 28 '20 02:01 nkurihar

Hi! I'm running into some issues due to the typings in DefinitelyTyped being out of date (namely, log missing, and listener-based consumer unrecognized in TS). Wouldn't it be easier to maintain the type definitions inside this source repository, and always ship them together? It seems like this would make keeping things in sync easier.

rkaw92 avatar Dec 08 '20 21:12 rkaw92

@rkaw92 You can submit a pull request to the definitely typings repo if you find anything outdated and it'll get merged.

bwalendz avatar Dec 17 '20 01:12 bwalendz

@rkaw92 Sent PR to DefinitelyTyped(pulsar-client). https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50229

If the PR was merged, I think you can set message listener for consumer.

shustsud avatar Dec 23 '20 08:12 shustsud

@bwalendz @rkaw92 I have added the type definitions to this repository: https://github.com/apache/pulsar-client-node/pull/140

massakam avatar Feb 09 '21 03:02 massakam

Closed as types are provided. This is a thin wrapper js package so JS or TS is not quite different. If anyone who wants to rewrite it in typescript (I suggest you don't waste time to do this), you can bring up this issue again with a prototype.

tisonkun avatar Apr 05 '23 07:04 tisonkun