Nenad V. Nikolić comments

Repositories
Issues
Comments

Results 3 comments of


                                            Nenad V. Nikolić

Ignore possibly overridden container hostname.

Thanks for getting back after all this time. I've amended my pull request as you requested - leaving out the version bump.

Add rule on not doing TODO comments

Do you mean by this that _TODO comments SHOULD be avoided in Scala_? Without further context, I'm assuming that this was the idea. Such rule/recommendation sounds reasonable as leaving notes/TODOs...

Kafka exporter: kafka_consumergroup_lag

HI @danielqsj, given than PR #466 has been merged and became a part of [v1.9.0 release](https://github.com/danielqsj/kafka_exporter/releases/tag/v1.9.0) can this issue be closed? And I have a question related to this very...