Ignore possibly overridden container hostname.

Open shonzilla opened this issue 9 years ago • 2 comments

If docker container hostname is overridden, the hostname in cgroups must be ignored. Hostname can be overridden using [-h|--hostname[=HOSTNAME]] docker run option.

Feb 12 '16 13:02 shonzilla

I am sorry for not noticing this earlier! This is definitely a needed improvement. Could you try to merge in latest master and fix any conflicts? I'll try to review and merge in after that. Also, please don't bump version in package.json — I'll bump that using npm versioning commands myself. Thanks!

May 25 '16 12:05 martintajur

Thanks for getting back after all this time. I've amended my pull request as you requested - leaving out the version bump.

May 30 '16 11:05 shonzilla

DEPRECATED (You can use following package instead: https://github.com/sindresorhus/is-docker)

Dec 02 '22 11:12 nikolajevp