Senbai Kang
Senbai Kang
Is there anyone running tests on the code? If you have concerns we can talk about it.
Hi @drighelli, Many thanks for the reply! And no worries, I completely understand :) Regarding your concern, if any of the four required columns do not exist, it will have...
Hi Dario, I have added a few lines of code for user-defined columns of `imgData` and the corresponding sanity check. I also added a unit test function named `imgData_1` in...
Hi Dario, It's been a while since we communicated last time. Could you let me know the status? Thanks, Senbai
Hi @lmweber, Thank you for the follow-up. Regarding the rational behind the additional custom columns in the `imgData`, it will allow us to add extra information of the image, e.g.,...
I quickly made some modifications to remove the dependencies, as well as testing it. Please double check and test it again :)
Hi Lukas, Your commits look great to me, thanks! Sorry for forgetting to remove `purrr` from the description file. Senbai
Hi Dario, Thanks for reviewing the code! To answer your question, the `...` argument passed to `SpatialExperiment()` indeed takes care of arguments of `SingleCellExperiment()`, `SummarizedExperiment()` and `addImg()`. The code I...
Hi @drighelli and @lmweber, I have added some tests for the additional arguments of the constructor. Please have a look and let me know if they are ok. Senbai
Sure, I will have a look when I get free.