Sophie Breitbart

Results 9 comments of Sophie Breitbart

Hi Jon- thank you for sharing these updates! I'll certainly work on updating the package to adapt to the new changes.

@julierose-NOAA Would you like to be credited as a contributor to this vignette?

> @sbreitbart-NOAA I can review this next week (5/12-5/16) - does that sound ok? Sounds great! Thanks Kathryn!

> This was a really helpful vignette. I looked through and the code makes sense to me, and I was able to successfully render the vignette locally. > > My...

> Hi @sbreitbart-NOAA - I have gone through it a couple of times trying to find any constructive feedback to give, and I really don't have anything I can suggest...

Hi @k-doering-NOAA ! Are you interested in / do you think you'll have capacity to review this PR within the next month or so? If not, I can ask someone...

> @sbreitbart-NOAA, that works for me! I will finish by 12/5 Super! Thanks so much, Kathryn!

> Hi Sophie, > > Overall, it looks good! I was able to run the example plot that uses the theme! I just had a few minor comments for your...

I have a few ideas: 1. For qualitative palettes, I'd recommend the [Okabe-Ito palette](https://clauswilke.com/dataviz/color-pitfalls.html#fig:palette-Okabe-Ito). It has 8 colors and supposedly works well for all color-vision deficiencies. 2. I'd also try...