nmfs-ost
Add cvd vignette
- Add first draft of vignette showing how to test palettes for usability to those with color vision deficiency, and provide alternatives for regional palette
- update xaringan vignette
Code Metrics Report
| Coverage | Code to Test Ratio | Test Execution Time |
|---|---|---|
| 54.5% | 1:0.3 | 5s |
Code coverage of files in pull request scope (54.5%)
| Files | Coverage |
|---|---|
| R/nmfs_cols.R | 54.5% |
Reported by octocov
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Code Metrics Report
| Coverage | Code to Test Ratio | Test Execution Time |
|---|---|---|
| 54.5% | 1:0.3 | 5s |
Code coverage of files in pull request scope (54.5%)
| Files | Coverage |
|---|---|
| R/nmfs_cols.R | 54.5% |
Reported by octocov
@julierose-NOAA Would you like to be credited as a contributor to this vignette?
@sbreitbart-NOAA I can review this next week (5/12-5/16) - does that sound ok?
@sbreitbart-NOAA I can review this next week (5/12-5/16) - does that sound ok?
Sounds great! Thanks Kathryn!
This was a really helpful vignette. I looked through and the code makes sense to me, and I was able to successfully render the vignette locally.
My main suggestion was for the vignette to reference the alt palettes already in the package rather than constructing new ones, or at least show how to access them at the very end. However, feel free to merge it as you feel it is appropriate!
Thank you for your review, Kathryn! I've answered your questions individually, below.
Code Metrics Report
| Coverage | Code to Test Ratio | Test Execution Time |
|---|---|---|
| 54.5% | 1:0.3 | 5s |
Code coverage of files in pull request scope (54.5%)
| Files | Coverage |
|---|---|
| R/nmfs_cols.R | 54.5% |
Reported by octocov
Hi @sbreitbart-NOAA - I have gone through it a couple of times trying to find any constructive feedback to give, and I really don't have anything I can suggest you improve upon! This is really easy to follow and informative, and I like how you walk through building the alternative color palettes. great work, and I'm happy to see some more options out there for CVD users!
Thank you so much for your clear and supportive feedback, Christine! I'll merge this in soon.