Savannah Manning
Savannah Manning
@whatyouhide made all the feedback changes! One thing I forgot to mention is the http_client module is still using Finch as an example to add your own.. Should this be...
> @savhappy what's the status on this? Ready for review or anything? CI fails for an unknown reason on certain Elixir versions.. Merging is blocked until these are resolved. @whatyouhide...
@whatyouhide should we have a flag that can be flipped to use Hackney instead of Finch after Finch is set as default? And apply this flag to the supervision tree...
PR out for this [switch-a-roo](https://github.com/getsentry/sentry-elixir/pull/758) @whatyouhide ^_^
@whatyouhide alright cleaned up the deprecated errors but my mix.lock seems to be out of sync. Master and this branch currently pass locally but fail when pushed. Final blocker before...
@whatyouhide yep yep I'll tag you here when ready
@whatyouhide ready for an initial review. I've only added a single instance of recording an event but will add in more after discussion
Thanks @whatyouhide for this! Updated with these comments except the blocking tests. Will add those shortly. Hold off on more feedback till I get the next round out. I need...
Question @whatyouhide : I need to add in the appropriate [data_category](https://github.com/getsentry/relay/blob/master/relay-base-schema/src/data_category.rs#L101) to the payload. We add the type only in the headers but other SDK's have a type field. The...
Yep! @whatyouhide The data categories are used to classify the type of data being ingested (ingest side types for collecting statistics). It's defined in the Client Report docs as ->...