sentry-elixir icon indicating copy to clipboard operation
sentry-elixir copied to clipboard

Switch from Hackney to Finch as the default HTTP client

Open whatyouhide opened this issue 1 year ago • 5 comments

Finch is really reliable and fast, and has significantly less dependencies than Hackney. It also exposes Telemetry events, whereas Hackney doesn't.

I think it would be nice to switch to it as the default client. We can leave Sentry.HackneyClient around for people that prefer it.

Thoughts @sl0thentr0py?

whatyouhide avatar Apr 21 '24 12:04 whatyouhide

yep sure if you think that's better, go for it!

sl0thentr0py avatar Apr 23 '24 08:04 sl0thentr0py

@whatyouhide should we have a flag that can be flipped to use Hackney instead of Finch after Finch is set as default? And apply this flag to the supervision tree upon start?

savhappy avatar Jul 06 '24 19:07 savhappy

No it's not necessary. We can just switch to Finch. If users want to use Hackney, they can write an adapter—maybe we can just put the Hackney Sentry client we have now in the codebase over into the docs if they want to copypaste that.

whatyouhide avatar Jul 06 '24 19:07 whatyouhide

PR out for this switch-a-roo @whatyouhide ^_^

savhappy avatar Jul 29 '24 20:07 savhappy

@whatyouhide alright cleaned up the deprecated errors but my mix.lock seems to be out of sync. Master and this branch currently pass locally but fail when pushed. Final blocker before another round of reviews

Image

savhappy avatar Mar 01 '25 00:03 savhappy