Sander
Sander
Design
Hi. If you're interested in updating the design away from the classic hackernews style and towards a more modern/accessible look, let me know. I'd love to contribute.
## Type - Enhancement ## Resolves the following issues / ## Pull request description This PR is an attempt to solve https://github.com/forkcms/forkcms/issues/3235, but isn't done. I've moved the original JSON...
Attempted fix for https://github.com/hollodotme/fast-cgi-client/issues/18. Implemented option 3 from [this comment](https://github.com/hollodotme/fast-cgi-client/issues/18#issuecomment-421124734). This timeout now also applies to the multi requests since the `getSocketIdsHavingResponse` has been reworked to simply use `hasResponse` in...
Branch started from https://github.com/hollodotme/fast-cgi-client/pull/74. 2 API improvements with a BC break: * `AbstractRequest->setContent` is removed, making the content of a request immutable. Content can only be defined when creating the...
This PR should be reviewed per commit. The first one https://github.com/hollodotme/fast-cgi-client/commit/5da4f532d68830d33d3a1f239922de604be94137 installs the [CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) package and adds some configuration. The second commit is optional, because it applies the PSR12 codestyle...
Running PHPStan, I noticed a couple of bugs that I missed in the previous PRs for 4.x. Mostly `newWithRequestContent` still being used, and wrong AbstractRequest constructor usage (still passing strings).
Could be a solution for https://github.com/thephpleague/route/issues/301, but it is definitely a solution for our use case. We'd like an easy way to read the matched Route during every step of...
Is there a reason the NPM package for @symfony/webpack-encore is still locked to 0.30? They recently released version 4.0 of both the PHP and JS package. Are you open to...
Lowercase folder names throw errors on Linux systems, which are case-sensitive. According to the PSR-4 spec, the folder should match the sub-namespace: https://www.php-fig.org/psr/psr-4/#2-specification > The contiguous sub-namespace names after the...