WIP: 405 page add block modal
Type
- Enhancement
Resolves the following issues
/
Pull request description
This PR is an attempt to solve https://github.com/forkcms/forkcms/issues/3235, but isn't done. I've moved the original JSON content into a hidden field and made an attempt to move it back into the editor textarea's value property when a cancel button is clicked (as discussed in the last comment of the linked issue) but this doesn't seem to work. I figured I have to either reload the EditorJS instance to parse the old content I've put back, or somehow revert the AJAX call that is made by? Maybe @carakas could take a look and see where we go from here?
Codecov Report
Merging #3454 (5aaf3d8) into restructure-core (9cfa136) will decrease coverage by
0.21%. The diff coverage isn/a.
@@ Coverage Diff @@
## restructure-core #3454 +/- ##
======================================================
- Coverage 32.81% 32.59% -0.22%
- Complexity 8724 8834 +110
======================================================
Files 651 658 +7
Lines 32106 32537 +431
======================================================
+ Hits 10534 10605 +71
- Misses 21572 21932 +360
| Flag | Coverage Δ | |
|---|---|---|
| functional | 26.22% <ø> (-0.16%) |
:arrow_down: |
| installer | 4.76% <ø> (-0.07%) |
:arrow_down: |
| unit | 12.08% <ø> (-0.10%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...iaLibrary/Domain/MediaItem/MediaItemRepository.php | 5.55% <0.00%> (-3.54%) |
:arrow_down: |
| src/Common/Doctrine/Entity/Meta.php | 45.07% <0.00%> (-1.49%) |
:arrow_down: |
| src/Frontend/Modules/Search/Engine/Model.php | 34.05% <0.00%> (-1.18%) |
:arrow_down: |
| src/Backend/Core/Engine/Meta.php | 59.55% <0.00%> (-0.45%) |
:arrow_down: |
| src/Frontend/Core/Engine/Page.php | 72.64% <0.00%> (-0.36%) |
:arrow_down: |
| src/Common/Core/Cookie.php | 66.66% <0.00%> (ø) |
|
| src/Backend/Core/Ajax/GenerateUrl.php | 0.00% <0.00%> (ø) |
|
| src/Backend/Modules/Settings/Actions/Index.php | 0.00% <0.00%> (ø) |
|
| src/Backend/Modules/Search/Actions/Statistics.php | 0.00% <0.00%> (ø) |
|
| src/Frontend/Modules/FormBuilder/Widgets/Form.php | 0.00% <0.00%> (ø) |
|
| ... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9cfa136...5aaf3d8. Read the comment docs.