Samuel Searles-Bryant

We do not support Django < 1.10 (the tests will not run because of an import of a package that does not exist prior to Django 1.10), so we should...

Replace django.conf.urls.url with django.urls.re_path

1

This avoid a deprecation warning: django.conf.urls.url is an alias for django.urls.re_path but will be removed in Django 4.0. This method was only added in Django 2.0, so we have to...

`pwa/urls.py` uses the deprecated `url()` function instead of its newer replacement: ``` RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path() ```

Upgrade node version to node16

2

GitHub has deprecated support for node12 in actions: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ To continue using this action after Summer 2023 the version of node must be updated. --- I would open a PR...

I'm seeing some false-positives from B906 where we have node visitors that are not using the stdlib `ast` library: ```python import libcst class CSTVisitor(libcst.CSTVisitor): def visit_ClassDef(self, node): pass ``` ```console...

Conventional file path/line number separator (`:` instead of `@`)

3

The output when a line is reported uses the `@` character to separate the filename from the line number, e.g: ``` path/to/some/module.py@91:12 An error is at this location. ``` This...

`fixit fix` exits with `0` even if there were errors

2

`fixit fix` will exit with an exit code of `0` if it finds errors but does not apply fixes. This makes using it in CI (or pre-commit hooks) awkward because...

`lint-fixme` comments not respected

3

`lint-fixme` comments on nodes in some cases are not respected. ## comprehensions In the following file (`t.py`), we would expect the violation to be reported for the first function, but...

Demonstrate fixme comments that are not being respected

2

## Summary ## Test Plan Failing tests have been added to demonstrate (most of) the bugs reported in #405. I have not been able to add one for the function...

It would be very helpful to be able to suppress the `# lint-fixme` comments to show those errors. In particular, this would help where an auto-fix has been added for...