Instagram
Demonstrate fixme comments that are not being respected
Summary
Test Plan
Failing tests have been added to demonstrate (most of) the bugs reported in #405. I have not been able to add one for the function definition problem because there are cases in this test that need to define functions without errors, so I can't just report functionDef.
Hi @samueljsb!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you so much for these examples! I've got a fix in #441, and squashed this PR with some additional test cases into #442 (retaining your authorship).
