Ryan S.

Function getReferenceContract()

1

Hello, Congratulations for all your work ! A quick remark: In [TREXImplementationAuthority.sol#L323](https://github.com/TokenySolutions/T-REX/blob/main/contracts/proxy/authority/TREXImplementationAuthority.sol#L323), the function `getReferenceContract()` does not check if `_trexFactory` is different from zero, which is a possible case. Therefore...

Add a CMTAT deployment version supporting [ERC-1363](https://erc1363.org). See also [ERC-1363 Standard Explained](https://www.rareskills.io/post/erc-1363) OpenZeppelin already supports this standard [ERC-1363.sol](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC1363.sol) The easier way to do this is to create a contract inheriting...

Emit event

1

We should emit events for variables initialized inside an initialize function

CMTAT Basic Version

1

Create a basic version of the CMTAT, with the minimum of module

Use bitmask for restrictionCode (RuleEngine) and flag of creditEvent as recommend by the audit 3.1 **CVF-9** > Consider replacing it with a functions that returns are bitmask of all valid...

**Gas optimization:** Use assembly to check address zero #228 **Deployment:** Create a basic version of the CMTAT #205 Create deploy script #188 & #61 Create a contract factory to deploy...

See https://github.com/CMTA/CMTAT/pull/70 We should reconsider this since : - Use uint8 instead of uint256 increase the gas cost since EVM works with uint256 - The ERC 1404 is not an...

Add a hashmap to store custom attributes

See https://www.rareskills.io/post/gas-optimization#viewer-7stcj

Revoke all roles in one function call

1

It could be interesting to have the possibility to revoke all the roles of an address, at the exception of the admin address, in one call. It is similar to...