Przemysław Rożnawski

Do we want to merge this PR?

I implemented most of the comment so far. I would like to implement those two suggestions in the next PR: > we should implement the same mechanism like in https://github.com/fishjam-dev/membrane_rtc_engine/pull/408...

The first script in ex_webrtc ```elixir alias ExWebRTC.PeerConnection {:ok, pc1} = PeerConnection.start_link() {:ok, pc2} = PeerConnection.start_link() {:ok, _transceiver_1_1} = PeerConnection.add_transceiver(pc1, :video, direction: :sendonly) {:ok, offer} = PeerConnection.create_offer(pc1) :ok = PeerConnection.set_local_description(pc1,...

With the following changes the echo example from ex_webrtc works on chrome: ```diff diff --git a/examples/echo/lib/echo/peer_handler.ex b/examples/echo/lib/echo/peer_handler.ex index 550c215..f3a2e33 100644 --- a/examples/echo/lib/echo/peer_handler.ex +++ b/examples/echo/lib/echo/peer_handler.ex @@ -16,11 +16,6 @@ defmodule Echo.PeerHandler...

We should not set the port to zero when creating answer if the transceiver is stopping. In the W3C specification, that is described in the `stop` method documentation: https://www.w3.org/TR/webrtc/#methods-8

When m-line is rejected it's port has to be set to 0, according to [RFC9429 section 5.3.1-15](https://datatracker.ietf.org/doc/html/rfc9429#section-5.3.1-15). This happens e.g. when no compatible media codecs could be found.

https://issues.chromium.org/issues/433898678

I’ll get back to you as soon as I can, though it likely won’t be until sometime next week. Appreciate your patience in the meantime