fishjam
fishjam copied to clipboard
Add logs about errors during adding peer
Acknowledging the stipulations set forth:
- [ ] I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
- [ ] I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.
Codecov Report
Attention: Patch coverage is 84.61538% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 87.19%. Comparing base (
07a89a9) to head (070852c).
Additional details and impacted files
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 86.89% 87.19% +0.30%
==========================================
Files 77 77
Lines 1549 1570 +21
==========================================
+ Hits 1346 1369 +23
+ Misses 203 201 -2
| Files | Coverage Δ | |
|---|---|---|
| lib/fishjam_web/controllers/fallback_controller.ex | 100.00% <100.00%> (ø) |
|
| lib/fishjam_web/controllers/peer_controller.ex | 100.00% <100.00%> (ø) |
|
| lib/fishjam/room_service.ex | 83.78% <60.00%> (-1.73%) |
:arrow_down: |
| lib/fishjam_web/controllers/room_controller.ex | 94.87% <33.33%> (-5.13%) |
:arrow_down: |
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 07a89a9...070852c. Read the comment docs.
Do we want to merge this PR?