Naman Aggarwal

Results 6 comments of Naman Aggarwal

Added List All Modules Option for CLI

@publiclab/is-reviewers

Histogram Module test passes even though it is not working

@publiclab/is-reviewers @HarshKhandeparkar @jywarren @blurry-x-face....

Histogram Module test passes even though it is not working

When I directly compared the base64, the test failed as it should.

Histogram Module test passes even though it is not working

I did removed the looks-same module in #1497, but then #1490 came and there were a lot of conflicts, so I recreated a new PR, keeping the looks-same module and...

Histogram Module test passes even though it is not working

According to me, this problem can be solved if we directly compare the base64 of the images... But before making changes we need to answer 2 questions... Can same image...

Use images instead of giant dataURLs for module tests

Okay I am on it...Once my GIF test PR got merge, because otherwise some file will conflict if I start working now...