image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Use images instead of giant dataURLs for module tests

Open harshkhandeparkar opened this issue 6 years ago • 2 comments

Please describe the problem (or idea)

Module tests currently store the expected output image as a dataURL in a variable. Instead, we need to load the image dynamically from a directory.

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

harshkhandeparkar avatar Jan 14 '20 15:01 harshkhandeparkar

Okay I am on it...Once my GIF test PR got merge, because otherwise some file will conflict if I start working now...

root00198 avatar Jan 15 '20 06:01 root00198

Pretty good solution just needs a rebase here: https://github.com/publiclab/image-sequencer/pull/1604

jywarren avatar Nov 01 '20 19:11 jywarren