Kevin Risden
Kevin Risden
From @ValTrofFuture on the Apache Calcite dev list: Executing steps described at these links https://calcite.apache.org/docs/howto.html#running-integration-tests https://github.com/vlsi/calcite-test-dataset shows this error when accessing Druid data: curl: (7) Failed to connect to localhost...
Wonder if this was caused by the recent Druid upgrade in PR #30 https://github.com/vlsi/calcite-test-dataset/pull/30/files#diff-4d687b6127479ccd0e9401aec6f5ae59L33 Looks like `wikiticker` was replaced with `wikipedia`? Maybe @nishantmonu51 or @jcamachor knows?
> It should execute in the same order, unless there's something "magical" about this being done from a different thread? @magibney I think this is because it is trying to...
Is there more to do here? I know @anshumg asked that Jetty 9.4.x upgrade be superseded by this change. There have been a few more Jetty 9.4.x and 10.x releases.
So my overall comment at looking at the underlying cause of the "out of order" is that it would be more clear to move the closes that order matters closer...
As described in the jira and here, the description and fix seems reasonable to me. I just don't know the code well enough in this part to say if this...
FWIW I went down this path in https://github.com/apache/solr/pull/699 and was told Jetty 10 was coming. I'm happy w/ this change though.
@HoustonPutman I haven't looked super closely at this, but I think that Hadoop shades curator when needed. Its possible that the Solr Hadoop classes just need to have the imports...
@madrob agreed would be nice to throw an exception potentially. Thanks for the reference as well looks plausible and shortens the shutdown time if things behave.
So fun fact - https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/concurrent/ExecutorService.html has the same example of this: ``` void shutdownAndAwaitTermination(ExecutorService pool) { pool.shutdown(); // Disable new tasks from being submitted try { // Wait a while...