solr icon indicating copy to clipboard operation
solr copied to clipboard
verified publisher icon apache

SOLR-16162: FilterQuery should implement DocSetProducer

Open magibney opened this issue 3 years ago • 7 comments

See: SOLR-16162

"producing a DocSet" is what FilterQuery is actually doing anyway; but more important practically: this avoids the cloning of the backing query's DocSet (and the creation of superfluous DocSets).

magibney avatar Apr 21 '22 21:04 magibney

As described in the jira and here, the description and fix seems reasonable to me. I just don't know the code well enough in this part to say if this should go in.

risdenk avatar May 06 '22 13:05 risdenk

Pending feedback/objections, I plan to merge this in the coming week.

magibney avatar May 11 '22 01:05 magibney

ha, thanks for noticing this one. I guess I missed the "coming week" window by more than a year 😅 . I'll take care of this shortly.

magibney avatar Aug 03 '23 14:08 magibney

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Feb 21 '24 00:02 github-actions[bot]