riktenx
riktenx
Do you still want this to be reviewed?
You will need to resolve conflicts if so.
@powerus117 Do you approve this change and author update?
There is a 99% chance that this is caused by a hub plugin that you have installed which messes with these lists. Try safe mode (disables all hub plugins and...
Are you interested in contributing this to the sailing plugin? Llemonduck previously expressed interest. If not I can review this as-is.
Support for hub plugins should be filed in the appropriate repo. This appears to already be filed under https://github.com/LlemonDuck/sailing/issues/78
https://github.com/runelite/runelite/wiki/Plugin-takeover-policy
Give the collaboration approach an honest try including reaching out to the authors. Beyond that it's up to the maintainers on whether they'll accept this submission or not.
We haven't forgotten about it but it's extremely large (~14k SLOC) and the plugin is doing some networking. This means it requires both an incredibly scrutinous _and_ lengthy review from...
> To be honest though this whole reviewing process thus far has been frustrating we are volunteers and this is FOSS IDK what to tell you my guy. i have...