runelite
Create blert v0.2.0
Blert is a PvM tracking and data analysis system hosted at https://blert.io.
This plugin collects data about players' raids and transmits it to the Blert servers to be processed and visualized.
Includes non-plugin changes
New plugin blert: https://github.com/blert-io/plugin/tree/26115482ff23407817e83cdb7ec5d3156b95d4e7
![runelite-github-app[bot] avatar](https://avatars.githubusercontent.com/u/13814776?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is a pretty large and complex project, so I'd be happy to discuss it in more detail as it is reviewed.
This should be ready to review now. Happy to chat about anything, and please reach out before merging.
The chances this gets reviewed in a timely manor is very low based on the number of dependencies added
No worries, I don't expect a quick review. Was just pointing out that I don't intend to make any further commits.
This would make the build non-reproduceable, please don't include it.
Removed the remote check, it wasn't actually being used.
On the dependency issue:
The plugin pulls in a single direct dependency (the protobuf compiler), which is quite large and has a bunch of transitives. However, this dependency is only required at build time to generate Java code from the plugin's .proto files. At runtime, the plugin reuses Runelite's existing version of the protobuf libraries and has no additional dependencies.
It is possible to remove the protoc dependency by manually running the compiler and checking in the generated Java protobuf code. This currently amounts to ~14.5K LOC (26K lines total) for serializing/deserializing protobuf messages to Java objects.
Does Runelite have a policy around checking in/reviewing generated code of this nature, and would it be preferable to eliminate the protoc dependency by doing so?
Do you still want this to be reviewed?
Yep, this is still active. Updated and resolved merge conflicts.
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.
Internal use only: Reviewer details Maintainer details