Ricky Stewart

icon indicating an email [email protected]

icon company @cockroachlabs icon location Chicago, IL icon location ricky

Results 32 comments of Ricky Stewart

sql: new heuristic-based completion engine

> Do you know how I can prevent dev generate bazel from adding the generated file to srcs? Yes -- add a comment to `BUILD.bazel` (probably the one in your...

sql: add a way for sequence caching to be per-node

Looks like this PR introduced a `race` build failure in `pkg/sql/sessiondatapb/sequence_cache_node.go` ``` pkg/sql/sessiondatapb/sequence_cache_node.go:47:8: sc.mu.RWMutex undefined (type syncutil.RWMutex has no field or method RWMutex) pkg/sql/sessiondatapb/sequence_cache_node.go:49:8: sc.mu.RWMutex undefined (type syncutil.RWMutex has no...

lint: make runnable under `bazel test`

bors r=rail

workflows: run examples-orms tests in GitHub Actions

First commit is from #119415 and can be ignored

workflows: run examples-orms tests in GitHub Actions

bors r=rail

Help users with duplicate copy_to_bin actions

I am also rubbing up against this. Unfortunately `rules_js` essentially demands that the source tree be structured a certain way, so you cannot solve this by trying to move one...

sql: add randomized test for plan-gist logic

bors r-

sql: add randomized test for plan-gist logic

Looks like you need to `dev gen bazel`, please check the CI results before `bors`'ing.

intentresolver: mark the test heavy to prevent OOM

Pre-emptions. bors r+

WIP on a memory leak fix

bors r+