cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

WIP on a memory leak fix

Open yuzefovich opened this issue 1 year ago • 2 comments

Epic: None

yuzefovich avatar Mar 01 '24 00:03 yuzefovich

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Mar 01 '24 00:03 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Mar 01 '24 00:03 cockroach-teamcity

This is RFAL. I'm including the last commit as a proof-of-concept, but I'm currently leaning towards not merging it.

yuzefovich avatar May 21 '24 02:05 yuzefovich

Thanks for all the reviews around the BytesMonitor infra! This is the last improvement I had in mind.

bors r+

yuzefovich avatar May 29 '24 20:05 yuzefovich

Build failed:

craig[bot] avatar May 29 '24 20:05 craig[bot]

bors r+

rickystewart avatar May 29 '24 20:05 rickystewart