Artem Mikheev

Various refactors and simple improvements

2

Hi, found you project and wanted to contribute a bit, since the only closest tool to this I know is written in python, so hopefully someday this ends up replacing...

Prometheus metrics are redundant and slow

43

While digging into Caddy's source code I've noticed that every (!) route handler is wrapped in a `metricsInstrumentedHandler` which updates Prometheus metrics during request execution. While it is a great...

Optimize PrepareRequest and req.Context lookups

38

Upon analyzing a profile of Caddy during benchmarking (with `h2load`), I found out that a large chunk of CPU time is eaten up by PrepareRequest, specifically the multiple context.WithValue being...

Gofumpt removing newlines before comments

7

Why has gofumpt started removing newlines when it isn't needed? e.g. this is a transformation I'm constantly seeing now Before formatting:  After formatting:  This just looks incredibly bad,...

ServerReflection doesn't respond with transitive dependencies as its supposed to by the standard

1

As seen in the implementation of gRPC reflection inside grpclib, only the single requested file descriptor proto is returned instead of the whole transitive dependency chain: https://github.com/vmagamedov/grpclib/blob/3c0fa03c3134a2d766ab050911bde81ebc9ecbae/grpclib/reflection/service.py#L57-L67 It is specified...