Joakim Recht

Use weakref for callback references

1

It would be nice if the callback was added to the internal subscriptions list as a weakref - that way callbacks (and the owning objects) can be garbage collected even...

Check types and params for optionals

9

If I have one provider like this: ``` type Params struct { fx.In Dep SomeDep `optional:"true"` } ``` and is `SomeDep` has a constructor function registered in Fx which is...

DemuxArena should use the same arena implementation as the source

1

If you marshal a SingleSegment and unmarshal it again, you get a MultiSegment. If you then start writing to that then you get several segments instead of using a single...

This happens when enabling ControlMaster in openssh. Seems to be related to https://github.com/golang/go/issues/13155. `~/.ssh/config` looks like this: ``` ControlMaster auto ControlPath ~/.ssh/master-%r@%h:%p ControlPersist 10m ```

Make it possible to extract fields from the context in the slog adapter

10

Since slog has context logging built in it would be nice to be able to utilize that with a zap handler, for example to log tracing context.

### Background information - **Dendrite version or git SHA**: 0.13.1 - **SQLite3 or Postgres?**: Postgres - **Running in Docker?**: Yes - **`go version`**: 1.19.7 - **Client used (if applicable)**: ###...

This makes it possible to print the entire hierarchy when using `%+v` - in particular, when running tests this will show causes and stack traces, not just the error message,...

Make TestWorkflowEnvironment return errors with stack traces

1

If a test fails, for example because a context is used wrongly, there's almost no information available to debug, and you have to go through error unwrapping and checking in...

The `scope.Counter`, `scope.Gauge`, `scope.Timer` funcs sanitize the name before cache lookups, which can add significant overhead. It would be nice to do sanitize after cache lookups instead - this is...

Invalid options syntax error

2

Trying to run the command, but I get this: ``` /target-determinator.linux.amd64 -verbose -targets //src/... d2181321315c9864e1ec5c533c4b5f3f1d2008b2 2023/08/24 00:27:38 Processing revision 'before' (sha: d2181321315c9864e1ec5c533c4b5f3f1d2008b2) 2023/08/24 00:27:38 Current working tree has 1 non-ignored...