Joakim Recht

Sure, but if I added it to the container and it's not valid shouldn't that trigger an error? Especially because I might not be in control of the optional tag.

I still don't understand why it's legal to register something into Fx which cannot be instantiated? It seems more or less trivial to look at all components registered and check...

That makes sense - I just assumed that's why optional exists, so that you can declare on the server provider that it doesn't need a handler. I get why it...

> This makes sense to me! I think the name WithFieldsFromContext is a bit more descriptive than WithContextExtractor. I can change it to that, but do you then have any...

Sorry for the late reply - we could do that instead, but it will lead to some amount of duplicated work. My specific use case is to add tracing info...

A small improvement would be to add ``` - action: keep_if_equal sourceLabels: [__meta_kubernetes_pod_annotation_prometheus_io_port, __meta_kubernetes_pod_container_port_number] ``` to the vmpodscape to avoid duplicates being emitted for pods with multiple ports

Unfortunately it's a large private monorepo, so I can't push it anywhere

I was looking around to see if anybody was working on extending callback handlers with the ability to correlate start and end events, and my guess is that's also going...

I did a quick change to `_TracingActivityInboundInterceptor` to add attach/detach calls, and then it works: ``` ctx = self.root._context_from_headers(input.headers) with self.root.tracer.start_as_current_span( f"RunActivity:{info.activity_type}", context=ctx, attributes={ "temporalWorkflowID": info.workflow_id, "temporalRunID": info.workflow_run_id, "temporalActivityID": info.activity_id,...

> This is a good start, but it needs some more work. > > 1. Most importantly, it should support range selection. It should be possible to press shift-down-arrow to...