Rafael Dohms

Results 48 comments of Rafael Dohms

yes, so a merged PR has: state: closed and merged: true, a closed PR has merged: false.

Not saying it isn't but there is nothing checking it, might be worth mentioning also.

I would not be able to test it all, all you need to do is copy the files and adjusts paths. The travis/scrutinizer side of it has to be done...

@deviouspk yes, I had originally planned to review and improve for here. Ideally without breaking BC and by introducing new asserts. I saw your description and it looks like a...

Original code is not mine so i'm also getting familiar with it. I agree inconsistency is bad, so let's outline some cases: - empty array subset - empty target array...

I really like this.

That would be only for the process of gathering the metrics from storage and formatting in text right? I think it's worth it if it's standard practice. PHP is not...

I'm honestly in favor of having the lock file so we can indeed control the dependencies. Long ago I advocated a lot for this. @LKaemmerling what do you think? It...

Yeah my idea would be add at least a status icon of the underlying pr/issue.

So i dug a little more. Seems no parser does the full job and this library has a second parameter that avoids parsing the schemas. Still it would be cool...