License, Travis and Scrutinizer

Open rdohms opened this issue 10 years ago • 5 comments

Having all of these parts would greatly increase user's faith in this library.

May i recommend looking at https://github.com/thephpleague/skeleton and following how they do these?

Should be an easy fix. You already have tests, but i also think PSR-2 would be a good fit.

Apr 06 '15 16:04 rdohms

Good Idea. It's suppose to be PSR-2. Where it isn't?

Apr 06 '15 17:04 mathiasgrimm

Not saying it isn't but there is nothing checking it, might be worth mentioning also.

Apr 06 '15 17:04 rdohms

Ok, will use the template, looks good. Are you willing to send the PR?

Apr 07 '15 11:04 mathiasgrimm

I would not be able to test it all, all you need to do is copy the files and adjusts paths. The travis/scrutinizer side of it has to be done by the repo owner.

Apr 07 '15 11:04 rdohms

Ok no prob

Apr 07 '15 12:04 mathiasgrimm