Ruslan Arutyunyan
Ruslan Arutyunyan
From my perspective if we don't explicitly list the default members the behavior is as they are there with `= default` marker. The argument for that is the destructor. I...
> Usage of `is_base_of ` instead of `is_same` in shift_left_right.pass.cpp file - yes, it makes sense. Regarding `struct next_to_last` - I don't see a sense, due to we have got...
what is the purpose of this patch? You are saying about different versions on oneDPL but I don't understand the use-case. Are trying to do not use sycl_defs as public...
@brycelelbach, @griwes, @dkolsen-pgi, @rodgert, @ldionne Hi everyone, **Bryce, David, Michal,** This PR implements prototype (as we see it) that shows feasibility of "Tag dispatching and customization points" to fulfill initial...
> @rarutyun Would it be possible to get a simple high level overview of what the agreed-upon tag dispatching mechanism is going to look like? This proposed PR appears to...
> @rarutyun, @MikeDvorskiy, @akukanov could you please approve this PR ? Sorry, I cannot, because from my understanding that's not what we agreed on. During the discussion we said that...
Other than my comments, looks good to me. I would also ask somebody to review the infrastructure part.
> I have tried to test the implementation locally and found that it enables the CTAD only for copy/move constructors of `blocked_rangeNd`. I had an idea on how can CTAD...
> OK, no problem. In that case the patch looks fine for me, except for copyright years that should be actualized. Thanks. And as you can guess, copyright issue is...
Hi Attila, Please find my response and questions below: > In our applications we've seen a couple of times already that we must not create sycl::queue objects in a global...