Investigate the possibility to change iterator tag checks for is_base_of semantics

Open rarutyun opened this issue 4 years ago • 4 comments

include/oneapi/dpl/pstl/utils.h file - struct next_to_last test/parallel_api/algorithm/alg.modifying.operations/shift_left_right.pass.cpp file - struct shift_right_algo

Feb 04 '21 22:02 rarutyun

Usage of is_base_of instead of is_same in shift_left_right.pass.cpp file - yes, it makes sense. Regarding struct next_to_last - I don't see a sense, due to we have got no code reduction....

Mar 22 '21 15:03 MikeDvorskiy

Usage of is_base_of instead of is_same in shift_left_right.pass.cpp file - yes, it makes sense. Regarding struct next_to_last - I don't see a sense, due to we have got no code reduction....

It's not about code reduction. It's a performance bug for C++20

Sep 28 '21 22:09 rarutyun

Threre are other places in the host backend which should be considered, e.g. https://github.com/oneapi-src/oneDPL/pull/395#discussion_r737243526

Oct 27 '21 09:10 dmitriy-sobolev

Implemented here https://github.com/oneapi-src/oneDPL/pull/376

Nov 10 '21 16:11 KseniiaBakina