Roi Atalla

Results 10 comments of Roi Atalla

Thanks a bunch! https://github.com/ra4king/OpenGL-Worlds/commit/fa67429ab93aac476708643ed1e72b5bd993b9da

From looking at the Canvas, GraphicsContext, and GrowableDataBuffer source, it seems this error can only happen from a race condition. It looks like `CircuitSim.updateCanvasSize` isn't wrapped in a `runFxSync` block...

Another similar report: ``` java.lang.RuntimeException: Must unlink port before removing it. at com.ra4king.circuitsim.simulator.CircuitState.ensureUnlinked(CircuitState.java:196) at com.ra4king.circuitsim.simulator.Circuit.lambda$null$9(Circuit.java:157) at java.lang.Iterable.forEach(Iterable.java:75) at com.ra4king.circuitsim.simulator.Circuit.lambda$removeComponent$12(Circuit.java:157) at com.ra4king.circuitsim.simulator.Simulator.runSync(Simulator.java:56) at com.ra4king.circuitsim.simulator.Circuit.removeComponent(Circuit.java:152) at com.ra4king.circuitsim.gui.CircuitBoard.lambda$removeElements$23(CircuitBoard.java:696) at com.ra4king.circuitsim.simulator.Simulator.runSync(Simulator.java:56) at com.ra4king.circuitsim.gui.CircuitBoard.removeElements(CircuitBoard.java:680) at...

I'm going to assume the fixes for issue #46 fixed this until I see a new report.

It happened again with 1.9.0 :( ``` java.version=17.0.5 java.vendor=Private Build java.vm.specification.version=17 java.vm.specification.vendor=Oracle Corporation java.vm.specification.name=Java Virtual Machine Specification java.vm.version=17.0.5+8-Ubuntu-2ubuntu122.04 java.vm.vendor=Private Build java.vm.name=OpenJDK 64-Bit Server VM java.specification.version=17 java.specification.vendor=Oracle Corporation java.specification.name=Java Platform API...

``` java.version=17.0.5 java.vendor=Private Build java.vm.specification.version=17 java.vm.specification.vendor=Oracle Corporation java.vm.specification.name=Java Virtual Machine Specification java.vm.version=17.0.5+8-Ubuntu-2ubuntu122.04 java.vm.vendor=Private Build java.vm.name=OpenJDK 64-Bit Server VM java.specification.version=17 java.specification.vendor=Oracle Corporation java.specification.name=Java Platform API Specification os.name=Linux os.arch=amd64 os.version=5.15.79.1-microsoft-standard-WSL2 CircuitSim version=1.9.0...

I reviewed these changes years ago but apparently my comments never actually went out for review, they were pending this whole time /facepalm

Hold ctrl and then scroll up, this lets you zoom in.

Hold ctrl and then scroll up, this lets you zoom in.