node-irc icon indicating copy to clipboard operation
node-irc copied to clipboard

Error in 'raw': cannot read property 'filter' on undefined in chanModes

Open ra4king opened this issue 9 years ago • 10 comments

I received this error after a MODE -b event occurreed. It looks like channel.modeParams[mode] is undefined and the filter function call was made on it on line 300 of irc.js. I'm patching it.

ra4king avatar Jun 25 '16 08:06 ra4king

Patch: #473

ra4king avatar Jun 25 '16 08:06 ra4king

I got the same error when removing quiet mask from a user. The patch(#473) fixed the issue.

sh1omi avatar Sep 15 '16 10:09 sh1omi

Happened also on my side:

TypeError: Cannot read property 'filter' of undefined
    at chanModes (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:296:37)
    at /home/medyk/irc-notifier/node_modules/irc/lib/irc.js:315:25
    at Array.forEach (native)
    at Client. (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:266:26)
    at emitOne (events.js:82:20)
    at Client.emit (events.js:169:7)
    at iterator (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:842:26)
    at Array.forEach (native)
    at Socket.handleData (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:837:15)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)

Any chance fix will land soon on npm?

medikoo avatar Oct 02 '16 10:10 medikoo

@medikoo no one updating the node-irc, you will need to update it urself or download from someone. You will need to change one line in irc.js https://github.com/sh1omi/node-irc/commit/fd0520a284ed5a13a33d7431d6baae063010fe2d

sh1omi avatar Oct 02 '16 10:10 sh1omi

@sh1omi you're trying to say that this project is no longer maintained? I don't see such info in main documentation.

medikoo avatar Oct 02 '16 10:10 medikoo

@medikoo yes. :) the last commit is from "Mar 27, 2016".

sh1omi avatar Oct 02 '16 11:10 sh1omi

@martynsmith can you confirm?

medikoo avatar Oct 02 '16 11:10 medikoo

still happening :(

ssachtleben avatar Nov 25 '16 12:11 ssachtleben

Hi, the issue still happens. Any outlook for a fix?

jimjaeger avatar Apr 21 '17 21:04 jimjaeger

@martynsmith The issue still exists. Can you merge the fix into the master branch? Or what do you need to?

jimjaeger avatar May 10 '17 18:05 jimjaeger