Raphael

Add EIP-5617: Non-transferable Token Standard

9

EIP for https://github.com/ethereum/EIPs/issues/1238

Failing tests: testGiveEOA() and testTakeEOA()

1

I was running the tests and noticed that `testTakeEOA` and `testGiveEOA` are failing with ``` [FAIL. Reason: _safeCheckAgreement: invalid signature] ``` It seems that it's because v is missing here:...

I'm confused by the behavior of this test. If I change this part here: https://github.com/rugpullindex/ERC4973/blob/1c8d612d78739c2f7bd8cae95be808bcbf3a1cae/src/ERC4973.t.sol#L337 to ``` uint256 tokenId = abt.take( passiveAddress, falseTokenURI, signature ); ``` I would expect the...

From my understanding of [CAIP-19](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-19.md), the tokenId suffix is optional, as in the example provided for DAI under [Test Cases](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-19.md#test-cases): ``` # DAI Token eip155:1/erc20:0x6b175474e89094c44da98b954eedeac495271d0f ``` However this test doesn't...

- Add `IERC1238Holdable` & `ERC1238Holdable` extension to let ERC1238 tokens be held by another account - Add `IERC1238Holder` interface that should be inherited by smart contract holding tokens - Start...