pinzart90
pinzart90
@aparajit-pratap Looks like you simply replace the IList with object without any regressions (asides from mending a few tests) I guess I am now thinking why we needed the IList...
> Curious if all the locking and unlocking for each and every smart collection operation has any performance impact? It looks like in most cases, it may be overkill to...
@mjkkirschner can you PTAL
> Do all machines need to have VS 2022 installed in order for this PR to pass? VS2019 should still work after this PR When we move to dotnet6 we...
> @pinzart90 looks like multiple versions of Greg.dll are referenced in your latest updates. I put in a lot of debugging/experimental code in here. I'll convert it to draft for...
Idea for more improvement is to DelayGraphExecution when calling `DynamoModel::GetConnectorsToAddAndDelete`. At this time...when hooking up a new node to an already connected node, Dynamo creates and schedules 2 UpdateGraphAsyncTasks.
Changed to draft PR temporarily while we look into some CICD issues.
@aparajit-pratap @mjkkirschner It looks like the API break check does not catch this change https://github.com/DynamoDS/Dynamo/pull/14940/files#diff-62203096f02fa171470a1ae45e23936dd6808ac8fc2aae936ef968d43675b057L119-R122 Should it ?
I think the changes in this PR need to be moved from DSOffice/Excel.cs to DSOfficeUtilities/Excel.cs We moved all Excel types/dependencies into DSOfficeUtilities because of issues with embedded types and the...
@Enkh-Od can you please attach the dyn file and any other files/logs that help reproduce this issue ?