Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

Refactor python engines api

Open pinzart90 opened this issue 2 years ago • 3 comments

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • [ ] The codebase is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated
  • [ ] This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

pinzart90 avatar Feb 14 '24 20:02 pinzart90

UI Smoke Tests

Test: success. 2 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests - net8.0

github-actions[bot] avatar Feb 14 '24 20:02 github-actions[bot]

@aparajit-pratap @mjkkirschner It looks like the API break check does not catch this change https://github.com/DynamoDS/Dynamo/pull/14940/files#diff-62203096f02fa171470a1ae45e23936dd6808ac8fc2aae936ef968d43675b057L119-R122 Should it ?

pinzart90 avatar Feb 14 '24 20:02 pinzart90

@aparajit-pratap @mjkkirschner It looks like the API break check does not catch this change https://github.com/DynamoDS/Dynamo/pull/14940/files#diff-62203096f02fa171470a1ae45e23936dd6808ac8fc2aae936ef968d43675b057L119-R122 Should it ?

no, @aparajit-pratap only added files for DynamoCore I think and we have yet to move any members to the shipped list. We need to schedule work to make use of this new system. We also need to decide about using warnings as errors. @jasonstratton FYI.

mjkkirschner avatar Feb 14 '24 20:02 mjkkirschner