Julien Verlaguet

icon company SkipLabs icon location New york

Results 5 comments of Julien Verlaguet

Libatomic issue

Try: $ cmake .. -DCMAKE_CXX_FLAGS='-Wno-local-type-template-args' Make sure to remove the _build directory, make sure cmake started from scratch. What is happening is that the "test" to check if libatomic is...

Fix: propagate updates when in a transaction

I agree with the fix. Maybe it might be worth adding a mechanism to make sure the update was called whenever the context was modified? If we tripped over it...

[skstore] Allow mappers to close only over handles

I think we can close this. @skiplabsdaniel has a more flexible approach that seems to make TS type-inference happy.

Use XXHash64 for all hashes

I thought I fixed that. Where do you still see use of crc64 for strings?

Use XXHash64 for all hashes

Ahhhh. Sorry I am on my phone, didn't pay attention to the repo. Yes we could switch to xxhash for everything. But this is low-pri no?