skdb icon indicating copy to clipboard operation
skdb copied to clipboard

Use XXHash64 for all hashes

Open mbouaziz opened this issue 5 months ago • 4 comments

Currently, we have crc64 to hash strings and murmur to combine hashes. Both are non-cryptographic. XXHash is faster than both with similar good properties. Crc64 could be better at detecting small changes but that's not what we're asking for here.

Any reason not to switch to xxhash for everything?

mbouaziz avatar Aug 20 '25 16:08 mbouaziz

I thought I fixed that. Where do you still see use of crc64 for strings?

pikatchu avatar Aug 20 '25 16:08 pikatchu

I'm talking about Skip, not skjs

mbouaziz avatar Aug 20 '25 16:08 mbouaziz

Ahhhh. Sorry I am on my phone, didn't pay attention to the repo.

Yes we could switch to xxhash for everything. But this is low-pri no?

pikatchu avatar Aug 20 '25 16:08 pikatchu

Kinda low-pri, but it'd:

  • make all Skip programs faster
  • simplify SkJS

mbouaziz avatar Aug 25 '25 13:08 mbouaziz