ollo22

Results 4 issues of ollo22

allow external SD card storage; cleanups

2 comment

This PR allows revancify users to set the apk target folder, via ``` internalStorage=/storage/XXXX-XXXX ~/Revancify/revancify ``` It also cleans up some problematic code, though plenty of it remains. I'll point...

failed cd's ignored, sometimes followed by rm -rf

In `revancify`, there are 3 instances of `cd ... || true`, followed by subsequent shell code. That's usually not a good idea. In two of the cases, the subsequent code...

exit from subshell; simplify checks for binaries

In `revancify` / `checkDependencies()`, ``` installdependencies || (echo "Dependencies not installed !!" && exit 1) ``` does not do what the author probably intended. The `exit` is contained in a...

pings in quick succession sometimes hang, leading to "network down" errors

I see this happen randomly on my Samsung A3x/A5x's. In https://github.com/decipher3114/Revancify/pull/24/commits/7df9e10418e6e4d4835cb73a66c16f164694c215 I've switched to a single check at the beginning of `revancify` (and `main.sh`, if somehow invoked independently, not from...