Revancify
Revancify copied to clipboard
failed cd's ignored, sometimes followed by rm -rf
In revancify, there are 3 instances of cd ... || true, followed by subsequent shell code. That's usually not a good idea. In two of the cases, the subsequent code does rm -rf on a path relative to the current directory (the one that the code possibly failed to cd into...)
I've fixed the rm -rf's to use absolute paths in https://github.com/decipher3114/Revancify/pull/24/commits/2536e17d074319519c8f4deaa5dd3c79b9f1eba4; however I think it should be cd .... || exit 1 most of the time, since executing subsequent actions in the wrong directory is a recipe for bad things.