Ofir Dagan comments

Results 24 comments of


                                            Ofir Dagan

Can't add separate 'keydown' and 'keyup' actions for the same key

seems like a bug in Mousetrap. I opened https://github.com/ccampbell/mousetrap/issues/284

Location keeps working when hiding map

Hey @simonettoa - I did not. It was for a POC project.

support rn > 0.40

@frostney - can u plz merge?

Inform parent on LocalStorage update.

Hi @jurkust , I'm sorry for the answer delay. From some reason the github mails reached my spam folder.. Now it's fixed. Regarding your change.. Cool feature! Please add tests...

Can not call methods of any angular service in the callback of any cross-domain-local-storage API

Hi bakkujp, I had a bug in xdLocalStorage but It's fixed now.. Please run 'bower update' and let me know if you're still having problems.

Can not call methods of any angular service in the callback of any cross-domain-local-storage API

Hi Bach, Sorry for the long delay. I can't reproduce this scenario. Can u please provide a snippet (plnkr/ jsFiddle) that reproduces the error? 10x!

iframeReady start value

did u run the tests? I didn't run in it for while. how come u need this change? what happens when it's true?

iframeReady start value

Hey, this change is w/o tests. I'm not maintaining this project anymore and I'm afraid to introduce changes that could cause regressions. Sorry.

Does not handle case where iframe fails to load

@loter - you can continue on prull request #19 and I'll merge. Currently it has conflicts..

Whitelist origin & Ng waitForApi fix

After you run ``` shell bower install npm install ``` you should run ``` shell grunt serve ``` This will run a local server on port 9000 and will run...