Nathan VanBenschoten

[dnm] demonstrate that dead code hits assertions

6

In https://github.com/cockroachdb/apd/pull/103, I'm looking into hooking up gcassert to CI. It's pretty magical to be able to add these assertions in and protect against regressions in carefully tuned code. I'd...

workload: use IMPORT parallelism proportional to available DistSQL pods in multi-tenant mode

1

In https://github.com/cockroachdb/cockroach/pull/78418, we addressed https://github.com/cockroachdb/cockroach/issues/75449 by using a parallelism of 1 when running IMPORT in multi-tenant mode. We set `numNodes` to 1 because we don't support DistSQL for IMPORTs in...

kv: pass explicit Now timestamp on BatchRequest, remove timestamp downcasting

2

First commit from #76233. This commit adds an explicit `ClockTimestamp` field called `Now` to the `BatchRequest` header, which mirrors the `Now` field on the `BatchResponse` header. In doing so, it...

kv: remove clock update on BatchResponse

2

Before this change, we were updating the local clock with each BatchResponse's WriteTimestamp. This was meant to handle cases where the batch request timestamp was forwarded during evaluation. This was...

NaN and +/-Inf Support?

4

Hi @vadimg, thanks for your work on this library. Have you considered adding support for the notions of either `NaN` or `+/-Inf`? If not, would you be opposed to me...

trace: make maximum active traces configurable

3

This commit adds a "max_active" query param to net/trace's `/debug/requests` HTTP handler. When provided, the parameter configures the maximum number of active traces to show. This allows users to override...

benchstat: accept io.Writer in FormatHTML, not *bytes.Buffer

1

This brings the API in-line with that of `FormatText` and `FormatCSV` and allows it to be used without necessitating an intermediate buffer. The change is fully backwards compatible and doesn't...

kv: stop sending InitPut, replace with CPut

1

First half of #71074. This commit replaces all client-side use of InitPut request with the equivalent use of CPut. It uses the following equivalence to perform this mapping: ``` InitPut(key,...

kv: remove ConditionalPutRequest.DeprecatedExpValue

1

This commit removes the ConditionalPutRequest.DeprecatedExpValue field, which was replaced by the ExpBytes introduced in 9e14f24. This has been possible since v21.1. Release justification: None, wait. Release note: None.

bulk: large index validation after backfill can be starved by GC TTL, bounding index creation scalability

1

After a backfill, we run a series of validation queries (`SchemaChanger.validateIndexes`) to ensure the integrity of the new index. These amount to full table scans over the new index and...