Nathan VanBenschoten
Nathan VanBenschoten
Yeah, I looked into whether there was a way to get debug information from either the branch elimination or (many) dead code analysis passes of gc, but from what I...
That does seem like a problem. How does `//gcassert:inline` work when added to a line with two function calls?
@bradfitz any chance you'd be willing to give this small patch [a review](https://go-review.googlesource.com/c/net/+/222675)? The engineers at CockroachDB have found that this change improves the utility of `net/trace`'s `/debug/requests` page significantly...
> Would there be interest in adding a fuzz function or three directly? Yes, any contribution (large or small) to improve the testing of this library would be appreciated.
@keithdoggett have you been able to reproduce while running just this single test, or does it require running the entire test suite? Have you been able to reproduce while running...
Thanks @keithdoggett, that's very helpful information! @rafiss has a Ruby env set up, so he's going to see how easily he can get this to fail when stressing the single...
I was able to reproduce this in 1 of 40 runs of the `activerecord` roachtest running on 7e38d69aadb0c294bef8e3f3746ac5b1362a1041. That commit includes the fix in https://github.com/cockroachdb/cockroach/pull/70744, which could have been one...
> I'm wondering whether that script performs txn retries in the same way as activerecord. Even when using https://pkg.go.dev/github.com/cockroachdb/cockroach-go/v2/crdb, I'm still not able to reproduce in Go.
@rafiss if you can get a reproduction with a crdb binary that includes https://github.com/cockroachdb/cockroach/commit/247332bc191a6d7bbcb043bf45509dc9517f78cf and is running with `--vmodule=replica_evaluate=2` then I can try to piece together a timeline of how...
I see something strange in those logs. Searching for locking Get operations on what I believe to be this key, I see the following logs: ``` I211018 21:27:28.872583 100401 kv/kvserver/replica_evaluate.go:521...