Nathan Cho

Results 12 comments of Nathan Cho

Sure! I will add commits without the `docs` folder.

I think it is a great idea. Would be awesome if the module can be lazy loaded :+1:

```ts import { getCalApi } from "@calcom/embed-react"; import { useEffect } from "react"; export default function Component() { useEffect(() => { getCalApi().then((cal) => { cal("on", { action: "bookingSuccessful", callback: (e)...

Any updates on this? I think this is a pretty critical bug preventing major workflows.

My current idea is having a muted text within the menu item describing the shortcut. For example: `[ICON] Rename column [ double click ]` `[ICON] Collapse column [ middle click...

This is how I'm envisioning showing the shortcut (the `Alt + Click` shortcut is just an example for the hint, not an actuao shortcut). Alternatively, we can consider pure icon...

Thanks for the follow-up! Got super busy this week, but will try to make the changes this weekend. Also on a different note, where else do you think this scroll...

That works too! Thought it might be a bit confusing/disappointing if the feature exists in some dialog and doesn't in others. But adding here first and refactoring later sounds like...

The only keyboard shortcuts affected are arrow up & arrow down. No changes are lost unless you close the dialog -- I tried to replicate the behavior on MacOS (or...

Sure thing, I'll create a PR later today. My implementation doesn't change anything in the backend, but it all works on a variable in the frontend. Here is a similar...