OpenRefine
feat: add history scroll on expression editor
Resolves #7255
Changes proposed in this pull request:
- Add keyboard up/down arrow shortcut for expression history
https://github.com/user-attachments/assets/66c3633c-8bd7-4e5f-bcab-72e9ebced941
This is an example for facet expressions, but it can be added to Text filter, Transform, etc.
Hey @ntcho, apologies for the delay in reviewing this. I've read through this and #7268 but I just want to spend more time using the new functionality locally. I'll have a review up in the next day or two for both PRs!
Hey @ntcho, just checking in to see if there's anything I can help out with here. Do you have any questions about my comments?
Thanks for the follow-up! Got super busy this week, but will try to make the changes this weekend.
Also on a different note, where else do you think this scroll functionality would be useful? I know there are few more expression editors across OR, it would be helpful to know where else to consider.
No worries! I just wanted to make sure you had all that you needed.
I'm sure there are other opportunities to apply this change, but I think for now it would make sense to stick with this one dialog and refactor/expand its usage in a later PR. What do you think?
That works too! Thought it might be a bit confusing/disappointing if the feature exists in some dialog and doesn't in others. But adding here first and refactoring later sounds like a better approach :)
Hey @ntcho, I was looking to close out some pull requests ahead of a 3.10 beta release, and I was wondering how much work you think it would take to close this out. Or, if you don't think you'll be able to find time to complete this, would you mind if I added the changes we talked about and finished this PR on your behalf?
Since this pull request has been open for a while without many changes, I'm going to go ahead and close it. We can always reopen it later if and when there's more time to dedicate to this feature.