Neil Shephard

Results 245 comments of Neil Shephard

I've started working on a code base that includes a Jupyter Notebook setup to run in Binder and have encountered this issue too. We have in our `requirements.txt`... ``` hide_code>=0.5.2...

Would love to see the pages generated by this site updated.

@aarya626 I don't think its quite that simple. In the example above the value passed to both is `np.deg2rad(30)` but it results in rotation in different directions for each. I...

@lagru My thinking was that if the option names are being aligned then, whilst multiplying by `-1` is possible perhaps the methods doing the calculations should also align as it...

I'll try and find time to have a look but pretty busy for a while. I had also noticed differences in output between the perimeter and filled objects and that...

Not looked at the code yet, and this may be part of the JSON output but there's no test to see what it looks like (sorry for banging the same...

> I have kept the saving in `processing.py` as I plan for `run_topostats` to be generic and not handle extra output from workflows in the future. Feel free to disagree...

:+1: Yes, definitely isolate the code into its own testable function. Test with small examples rather than full data set if possible too (even smaller than the cropped picture is...

Definitely agree with this, if we can make it so each step can be run in isolation it will give users greater flexibility and that was the thinking behind #517...

Feels like we're well on the way to achieving this with the refactoring @SylviaWhittle undertook which was merged in #613. What more needs doing to round this out? Is it...