Markus Olsson
Markus Olsson
## Description Building on #14174, this PR centralizes the logic for creating, and caching, Intl.* formatters. This is mainly a cleanup PR but sharing this (semi-complex) logic will minimize the...
Closes #1245 ## Description ~~Back in 2017 I wrote *"I'm leaning towards trying to solve this properly."* in response to our first attempt at fixing #1245 (https://github.com/desktop/desktop/pull/1257). Now, 5-ish years...
Closes #13943 ## Description This adds ~~region-aware~~ formatting for relative and absolute dates using the [`Intl`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl) namespace. This builds on #14149, #14123 and [app.getLocaleCountryCode](https://www.electronjs.org/docs/latest/api/app#appgetlocalecountrycode) Note that this is not about...
Closes #14868 ## Description The app menu on Windows is rendered in-app using the AppMenuBar component which in turn uses the MenuPane component. The MenuPane renders its list items using...
:wave: We ran into a bit of a problem in a recent beta version of GitHub Desktop. A seemingly uncontroversial refactor of some of our database logic caused a `PrematureCommiteError`:...
:wave: We, the GitHub Desktop Team, are happy users of prebuild in several projects that we depend upon. We've recently been working on yet another native module and ran into...
### The problem The unified diff mode highlights invisible unicode characters with a red dot and a tooltip on hover. The split diff doesn't ### Release version prod ### Operating...
## Description This cleans up some old build system logic and moves our code signing certificates into repository secrets. ### Screenshots ## Release notes Notes: no-notes
## Description While reviewing the release PR I noticed this pattern: https://github.com/desktop/desktop/blob/742b4c44c39d64d01048f1e85364d395432e3413/app/src/lib/stores/app-store.ts#L6656-L6658 Which stood out to me as being a computationally ineffective way to sort large arrays. Since .indexOf is...
@isaacmbrown clued us in on the fact that our Preferences menu item on macOS has all of a sudden become "Settings" instead Turns out this is because macOS Ventura has...