Markus Olsson

@sergiou87 Merge conflict, need a little ✅ again please

> Sorry @niik I didn't review it yet, only left that dumb comment 😅 I'll review it tomorrow first thing in the morning! No rush!

Alright, after significant investigation here we've determined that we're not quite ready to jump on the regional-aware train just yet. There are some notable en-* locales that isn't defined in...

Hey @Sergio0694, thanks for reporting this! Given how the syntax highlighting mechanism in Desktop works (reading the raw contents of the file from the working directory and the raw contents...

Yeah, this is definitely due to hiding whitespace. The syntax highlight tokenizer operates on the files with whitespace preserved which is what caused it to get offset like that. If...

> @niik this issue looks like duplicate of #11681, which is in the backlog 🤔 Cheers @tsvetilian-ty! Given the ongoing discussion in this I feel we should close that and...

So this will also be affected by https://github.com/desktop/desktop/pull/14173#issuecomment-1072293321. Given that we're switching to `en-US-POSIX` by default there will be no number grouping for now. @sergiou87 @tidy-dev One thing that will...

Hey @romainmenke, thanks for wanting to contribute to GitHub Desktop and thanks for the suggestion! I especially appreciate that you provided a clear use case for your request. I can...

Hey @maifeeulasad, thanks for reaching out! It looks like you are using an older version of Node.js than what's required. > ``` > PS D:\projects\desktop> node -v > v14.18.0 >...

> the only thing that was different was sub menu rendering, which I think we only have for dev builds (Show popup) and renders like this: Yeah, I was a...