Niels Lange

Results 49 issues of Niels Lange

Fixes #1595 This PR is an extension of #1771 and adds support for the submenu description. @gigitux mentioned this specific problem in https://github.com/woocommerce/storefront/pull/1771#issuecomment-1087301359. In this PR, I simply enhanced the...

status: blocked

Similar to https://github.com/woocommerce/woocommerce/tree/master/tests/e2e-tests#how-to-run-an-individual-test, having e2e tests in place might help to reduce bugs while implementing new features and updating existing features. Update: we've started work on this (#1394) and there's...

type: enhancement
Epic
priority: normal

While working on #5552, I noticed that we have functionality for the star rating in the following two different places: 1. https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/trunk/assets/js/atomic/blocks/product-elements/rating/block.js 2. https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/trunk/assets/js/base/components/reviews/review-list-item/index.js This violates the [DRY principle](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) and...

type: enhancement
category: refactor
πŸ”Ή block-type: reviews
πŸ”Ί atomic-block

While working on translations for the WooCommerce plugin, I noticed various mistakes in an original string. - [Link in Trac](https://plugins.trac.wordpress.org/browser/woocommerce/trunk/src/Database/Migrations/CustomOrderTable/CLIRunner.php#L438) - [Link on WordPress.org](https://translate.wordpress.org/projects/wp-plugins/woocommerce/dev/de/default/?filters%5Boriginal_id%5D=13834180) ### Original code ```php _n( '%1$d...

Fixes #1932 Before: ![#1932-before](https://user-images.githubusercontent.com/3323310/79983172-91f4eb00-84d1-11ea-89da-95379b8982e6.png) After: ![#1932-after](https://user-images.githubusercontent.com/3323310/79983179-94574500-84d1-11ea-8431-41d36e99c955.png)

Fixes #1905 Editor Before: ![#1905-editor-before](https://user-images.githubusercontent.com/3323310/79122147-36d04380-7dc1-11ea-9e34-d5b6f0746409.png) Editor After: ![#1905-editor-after](https://user-images.githubusercontent.com/3323310/79122150-389a0700-7dc1-11ea-846f-6881f627bad6.png) Frontend Before: ![#1905-frontend-before](https://user-images.githubusercontent.com/3323310/79122175-464f8c80-7dc1-11ea-9813-bcb9f2b13d5d.png) Frontend After: ![#1905-frontend-after](https://user-images.githubusercontent.com/3323310/79122178-48195000-7dc1-11ea-9c9e-c60300de9589.png)

[Status] Needs Testing

Fixes #272 Before: After:

[Status] Needs Testing

Fixes #1506 Before: ![#1506 - before](https://user-images.githubusercontent.com/3323310/66467647-f957ca00-eaae-11e9-8930-c580a04dd11f.png) After: ![#1506 - after](https://user-images.githubusercontent.com/3323310/66467654-fc52ba80-eaae-11e9-87db-6f459cddfe5d.png) @iamtakashi As `.wp-block-gallery { ... }` had been overwritten, I've increased the CSS specificity to `figure.wp-block-gallery { ... }` in...

**Steps to reproduce** 1. Create a guest author account (guest-780) 2. Check post count for admin and guest author 3. Create one post (test-post-780) as guest author and remove admin...

type: bug
status: needs investigation
priority: medium

**Steps to reproduce** 1. Create an editor account (editor-779) 2. Create one post (test-post-779) 3. Create a guest author account (guest-779) 4. Add guest author to post (test-post-779) 5. Check...

type: bug
status: needs review
priority: medium