Niels Lange

Results 152 comments of Niels Lange

Hello @haszari πŸ‘‹ After running into various errors when using [Jest](https://jestjs.io/) and [Puppeteer](https://github.com/puppeteer/puppeteer) I went ahead and experimented using [Cypress](https://www.cypress.io/). I understood that you prefer reusing the implementation from the...

@arunsathiya I looked up this case and as the full-size images are used for the Lightbox feature, reducing their size would lead to smaller Lightbox images. In your description above...

I just had an idea of which I'm not sure if it's genius or nuts. I thought by myself, what about creating four (resp. eight) different styles: - phone.scss β†’...

> Looks like this issue may have been introduced in 2.5.5 with #1261. We can look at reverting that fix or improving this in 2.5.6. I'll look this issue and...

Hello @asafm7 πŸ‘‹ Thanks for reporting this issue. I created the PR https://github.com/woocommerce/storefront/pull/1472 which needs to be checked and possibly adjusted. Cross fingers that testing goes smooth and this change...

Hello @jacoswan πŸ‘‹ Thanks for the video. This is very helpful.

Reported in 2766114-zen (Mentioned in https://github.com/woocommerce/storefront/issues/1286 by @anant1811)

@haszari As this issue is related to the WooCommerce core rather than the Storefront theme, can this ticket be closed?

Reopening this issue, as this issue it not caused by WooCommerce but by Storefront. WooCommerce already uses `text-decoration: none;` for this element in https://github.com/woocommerce/woocommerce/blob/f25967d57bc50c2906c94c111966d1bdbac04d1f/assets/css/woocommerce.scss#L1361-L1367. However, Storefront dequeues the WooCommerce styles...

> I think this means that this issue could be fixed in either place - and I'm not sure what the best solution is. I'm happy to keep both issues...